Merged
Conversation
added 2 commits
April 19, 2026 19:55
Validates http/https URLs using the url crate; normalises scheme and host to lowercase on construction. Closes #11
url 2.5.x pulls in icu_* 2.2.0 which requires rustc 1.86. Pinning to ~2.4 keeps idna at 0.4.x (unicode-normalization based). Also marks Website as done in ROADMAP.md, updates README feature table and roadmap summary, and adds Website reference to docs/contact.md.
codegresscom
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Websitevalue object in thecontactmodulehttpandhttpsschemes only; rejectsftp, bare strings, etc.urlcrateis_https()andhost()convenience accessorsurldependency to thecontactfeature flagType of change
Checklist
ValueObjecttrait contract (new,value,into_inner)TryFrom<&str>implementedDisplayimplementedserdesupport viacfg_attrtry_from_strcargo fmtandcargo clippycleancargo test --features contactpassesCloses #11