Skip to content

Add Website (contact)#81

Merged
codegresscom merged 2 commits intomainfrom
feat/11-contact-website
Apr 19, 2026
Merged

Add Website (contact)#81
codegresscom merged 2 commits intomainfrom
feat/11-contact-website

Conversation

@vhrcgcom
Copy link
Copy Markdown
Collaborator

Summary

  • Implements Website value object in the contact module
  • Accepts http and https schemes only; rejects ftp, bare strings, etc.
  • Normalises scheme and host to lowercase on construction via the url crate
  • Adds is_https() and host() convenience accessors
  • Adds url dependency to the contact feature flag

Type of change

  • New value object / feature

Checklist

  • Follows the ValueObject trait contract (new, value, into_inner)
  • TryFrom<&str> implemented
  • Display implemented
  • serde support via cfg_attr
  • Tests: valid input, empty input, invalid format, normalisation, try_from_str
  • cargo fmt and cargo clippy clean
  • cargo test --features contact passes

Closes #11

Václav Hrach added 2 commits April 19, 2026 19:55
Validates http/https URLs using the url crate; normalises scheme and
host to lowercase on construction.

Closes #11
url 2.5.x pulls in icu_* 2.2.0 which requires rustc 1.86.
Pinning to ~2.4 keeps idna at 0.4.x (unicode-normalization based).

Also marks Website as done in ROADMAP.md, updates README feature
table and roadmap summary, and adds Website reference to docs/contact.md.
@codegresscom codegresscom merged commit eded980 into main Apr 19, 2026
14 checks passed
@codegresscom codegresscom deleted the feat/11-contact-website branch April 19, 2026 18:02
vhrcgcom pushed a commit that referenced this pull request Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Website (contact)

2 participants